REFACTOR Make queue_job dependencies optional

[ecino]

• NEW module queue_job_sh_safe that will safely use queue_jobs when available and fallback to an alternate mechanism with ir_cron in case the module is not installed.
• This is useful for Nordic using odoo.sh on which queue jobs are prohibited and not optimal for the infrastructure

[gemini-code-assist]

Code Review

This pull request replaces the dependency on queue_job with queue_job_optional across several modules, transitioning from standard with_delay calls to with_delay_sh for asynchronous execution. It also attempts to make dictionary access safer when retrieving product_id and contract_id in bank_statement_line.py. However, the reviewer identified a potential TypeError in this safe-access implementation if the fields are present but set to False (the standard representation for empty many2one fields in Odoo), and provided a code suggestion to resolve this issue.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[greptile-apps]

Confidence Score: 4/5

The change is not ready to merge until the manifest dependency name is corrected.

The touched area is narrow and the main issue is a concrete install/upgrade blocker in the module dependency declaration.

account_statement_import_compassion_ee/manifest.py and recurring_contract/manifest.py

T-Rex Logs

What T-Rex did

• Reproduced the dependency resolution failure by running the generated Odoo-style manifest dependency resolver against the repository addon path; it exited with code 1 because account_statement_import_compassion_ee declares queue_job_optional but no local addon with that technical name exists.
• Compared with_delay scheduling behavior before and after changes; the base path raised AttributeError when queue_job/with_delay was unavailable, and the head path used a with_delay_sh fallback.
• Verified the statement-import-queue-fallback behavior by comparing before and after commits: the base state failed with AttributeError, while the head state calls FALLBACK_CALLED with with_delay_sh and exits 0.
• Tested handling of falsy and empty fields for product_id and contract_id: the base state raised TypeError and IndexError for certain cases, while the head state returned successfully for all falsy/empty cases and continued to return first-element IDs for tuple/list cases.

_{Ran code and verified through T-Rex}

_{Reviews (3): Last reviewed commit: "Merge branch '18.0' into ecino/queue-job..." | Re-trigger Greptile}

[greptile-apps]

Fix dependency name
The manifests now depend on queue_job_optional, but this repository does not add that module and the PR description names the new compatibility module as queue_job_sh_safe. With the current dependency, Odoo cannot install or upgrade account_statement_import_compassion_ee or recurring_contract unless an unrelated addon named queue_job_optional is present in the addons path.

Artifacts

Repro: generated manifest dependency resolver script

• Contains supporting evidence from the run (text/x-python; charset=utf-8).

Repro: resolver terminal output showing missing queue_job_optional dependency

• Keeps the command output available without making the summary code-heavy.

_{Ran code and verified through T-Rex}

[ecino]

LGTM