14.0 invoicing fix

[ecino]

No description provided.

[gemini-code-assist]

Code Review

This pull request removes the dependency on account_reconciliation_widget from the account_offbalance_sponsorship manifest and updates the explanatory comments regarding invoice generation offset calculations in contract_group.py. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[greptile-apps]

Confidence Score: 5/5

Safe to merge with minimal risk.

The diff only removes one manifest dependency and updates comments around existing invoice generation logic. No runtime behavior changes or supported bugs were identified.

No files require special attention.

T-Rex Logs

What T-Rex did

• T-Rex ran a baseline execution of the pre-fix range formula for invoicing, capturing the baseline results in invoicing-01-before.log which shows [0] / count 1 instead of 2.
• T-Rex executed the updated harness against changed files; manifest dependency checks passed and invoice counts matched the updated expectations, including yearly offsets [0, 12] / count 2, as recorded in invoicing-02-after.log.
• T-Rex ran compileall to validate Python modules, with recurring_contract and account_offbalance_sponsorship compiling successfully (exit code 0) as shown in invoicing-compileall.log.
• T-Rex evaluated environment availability and confirmed that a full Odoo/PostgreSQL/Docker stack was unavailable, supporting the fallback service-level validation documented in invoicing-odoo-availability.log.

_{Ran code and verified through T-Rex}

Important Files Changed

Filename	Overview
account_offbalance_sponsorship/manifest.py	Removes the direct dependency on account_reconciliation_widget; no changed code path still requires that module from the diff reviewed.
recurring_contract/models/contract_group.py	Clarifies invoice offset comments without altering the invoice generation loop or runtime behavior.

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
participant Module as account_offbalance_sponsorship
participant Odoo as Odoo module loader
participant Contract as recurring.contract.group
participant Invoicer as recurring.invoicer

Module->>Odoo: declare dependencies
Note over Module,Odoo: `account_reconciliation_widget` is no longer required
Contract->>Contract: _calculate_start_date_and_offset()
loop invoice offsets
    Contract->>Contract: _should_skip_invoice_generation(date, contracts)
    alt invoice needed
        Contract->>Invoicer: _process_invoice_generation(invoicer, date)
    end
end

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
participant Module as account_offbalance_sponsorship
participant Odoo as Odoo module loader
participant Contract as recurring.contract.group
participant Invoicer as recurring.invoicer

Module->>Odoo: declare dependencies
Note over Module,Odoo: `account_reconciliation_widget` is no longer required
Contract->>Contract: _calculate_start_date_and_offset()
loop invoice offsets
    Contract->>Contract: _should_skip_invoice_generation(date, contracts)
    alt invoice needed
        Contract->>Invoicer: _process_invoice_generation(invoicer, date)
    end
end

Loading

_{Reviews (1): Last reviewed commit: "Fix invoice loop for starting_offset=1 p..." | Re-trigger Greptile}