[MIG] Forward-port changes from 14.0

[ecino]

No description provided.

[greptile-apps]

Confidence Score: 4/5

T-Rex Logs

What T-Rex did

• Validated the focused PR 1787 country filter validation script and recorded the validation output to verify the P2 finding.
• Produced a second P2 finding proof detailing duplicate-country assignment, using the PR 1787 country-assignment check script and examining current behavior.
• Submitted an additional P2 finding proof covering another angle of the same issue, to broaden the validation scope.
• Conducted a general contract validation that confirmed identical filenames across runs and that removing the duplicate reduced country.name reads from two to one, with before/after visuals and logs.

_{Ran code and verified through T-Rex}

Comments Outside Diff (1)

1. General comment

   Redundant country assignment is dead before filename construction

   • Bug
     • child_order_picture.py lines 116-117 assign the same country expression twice consecutively. The first value is overwritten before fname reads country, so deleting line 117 or 116 (leaving one assignment) preserves the produced filename.
   • Cause
     • A duplicated source line assigns the identical right-hand-side expression to the same local variable with no intervening read or mutation.
   • Fix
     • Remove either one of the two identical country = child.field_office_id.country_id.name or "ZZ" assignments.

   _{Ran code and verified through T-Rex}

_{Reviews (1): Last reviewed commit: "[MIG] Forward-port changes from 14.0" | Re-trigger Greptile}

[greptile-apps]

Duplicate Country group-by filter

This adds a second Country filter immediately after the existing one with the same name, empty domain, and child_country_id group-by context. Users consequently receive two indistinguishable Country choices in the Group By menu; remove the duplicate declaration.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Artifacts

Focused PR #1787 Country filter validation script

• The exact Node and Playwright script executed against the parent and PR revisions parses the targeted view and records comparable menu captures, confirming the duplicate condition.

Focused validation command output

• The captured command output reports one Country group-by filter before the PR, two after it, and confirms that the two post-PR filters are identical.

▶ Group By menu before PR #1787 with one Country option

• The Playwright Chromium capture renders the menu derived from the parent revision and shows one Country Group By entry.

Poster frame before PR #1787 with one Country option

• The poster frame shows the parent-revision menu with a single Country Group By entry.

▶ Group By menu after PR #1787 with duplicate Country options

• The Playwright Chromium capture renders the menu derived from the PR revision and shows two indistinguishable Country Group By entries.

Poster frame after PR #1787 with duplicate Country options

• The poster frame shows the PR-revision menu containing two identical Country Group By entries.

_{Ran code and verified through T-Rex}

[greptile-apps]

Redundant country assignment before filename construction

country is assigned the identical expression twice consecutively, and the second assignment overwrites the first before fname reads it. Removing either assignment preserves both the normal country-prefixed filename and the ZZ fallback while eliminating dead code.

Artifacts

PR 1787 country-assignment check script

• Authored and executed Python script parses the target AST, asserts the adjacent duplicate assignments, and runs before/after filename construction, proving the narrow control-flow condition and filename equivalence.

Current duplicate-assignment behavior

• Captured execution of the authored check with both assignments present, showing lines 116 and 117 are identical and adjacent and producing Switzerland and fallback-ZZ filenames.

Behavior after duplicate removal

• Captured execution of the authored check with one assignment removed, producing the same Switzerland and fallback-ZZ filenames, so duplicate removal preserves filename output.

_{Ran code and verified through T-Rex}