CoordinateSource pixel_size handling - #1295
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1295 +/- ##
========================================
Coverage 90.52% 90.53%
========================================
Files 132 132
Lines 14209 14219 +10
========================================
+ Hits 12863 12873 +10
Misses 1346 1346 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
j-c-c
reviewed
Jun 26, 2025
j-c-c
left a comment
j-c-c
left a comment
Collaborator
There was a problem hiding this comment.
This looks good. Just one questions and a couple typos if you feel like changing them.
garrettwrong
marked this pull request as ready for review
June 26, 2025 18:23
janden
requested changes
Jul 1, 2025
janden
left a comment
janden
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Just one thing.
| :param max_rows: Maximum number of particles to read. (If `None`, will attempt to load all particles) | ||
| :param B: CTF envelope decay factor | ||
| :param symmetry_group: A `SymmetryGroup` object or string corresponding to the symmetry of the molecule. | ||
| :param pixel_size: Pixel size of the images in angstroms, default `None`. |
Collaborator
There was a problem hiding this comment.
We should indicate what None means in this context (auto-assign from CTF if possible).
Collaborator
Author
There was a problem hiding this comment.
Sure I changed the three occurrences to the following
:param pixel_size: Pixel size of the images in angstroms.
Default `None` will attempt to infer `pixel_size` from
`CTFFilter` objects when available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
pixel_sizeto initializer for CoordinateSources. Also add basic test for the explicit, None, and mismatch case.