Skip to content

Update Pipeline Demo - #1297

Merged
garrettwrong merged 9 commits into
developfrom
pipeline
Jul 8, 2025
Merged

Update Pipeline Demo#1297
garrettwrong merged 9 commits into
developfrom
pipeline

Conversation

@j-c-c

@j-c-c j-c-c commented Jun 26, 2025

Copy link
Copy Markdown
Collaborator

Updates pipeline demo to use defaults for common-lines and class averaging. Also begins with high resolution simulation. Added BOT Align and FSC.

Related #1284

@j-c-c j-c-c self-assigned this Jun 26, 2025
@j-c-c j-c-c added documentation Improvements or additions to documentation cleanup labels Jun 26, 2025
@codecov

codecov Bot commented Jun 26, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.60%. Comparing base (0afa283) to head (804f212).
Report is 9 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1297   +/-   ##
========================================
  Coverage    90.60%   90.60%           
========================================
  Files          133      133           
  Lines        14346    14346           
========================================
  Hits         12998    12998           
  Misses        1348     1348           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j-c-c

j-c-c commented Jul 1, 2025

Copy link
Copy Markdown
Collaborator Author

Added additional preprocessing steps and switched to using ground truth rotations to align the volumes for FSC.

Attaching a pdf of the demo as it is now.
Ab-initio Pipeline Demonstration — ASPIRE 0.13.2 documentation.pdf

@j-c-c
j-c-c requested a review from garrettwrong July 1, 2025 14:19

@garrettwrong garrettwrong left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, couple things in there. After you tweak it, send it back and I'll render it locally for another review when rendered as the webpage. Thanks!

Comment thread gallery/tutorials/pipeline_demo.py
Comment thread gallery/tutorials/pipeline_demo.py Outdated
Comment thread gallery/tutorials/pipeline_demo.py Outdated
Comment thread gallery/tutorials/pipeline_demo.py Outdated
Comment thread gallery/tutorials/pipeline_demo.py Outdated

@garrettwrong garrettwrong left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if changed, was missed before, or if I'm doing something incorrect, but when I render I get the following in Download an Example Volume

sphinx_gallery_start_ignore flake8: noqa sphinx_gallery_end_ignore

Comment thread gallery/tutorials/pipeline_demo.py
@j-c-c

j-c-c commented Jul 2, 2025

Copy link
Copy Markdown
Collaborator Author

Not sure if changed, was missed before, or if I'm doing something incorrect, but when I render I get the following in Download an Example Volume

Ah yeah, that needed to be in it's own cell. Fixed now. Thanks for spotting that!

@j-c-c
j-c-c requested a review from garrettwrong July 2, 2025 14:52

@garrettwrong garrettwrong left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks!

@j-c-c
j-c-c marked this pull request as ready for review July 2, 2025 15:56
@j-c-c
j-c-c requested a review from janden as a code owner July 2, 2025 15:56
@garrettwrong

Copy link
Copy Markdown
Collaborator

We should probably move on this so I can begin testing for release, thanks.

@garrettwrong

Copy link
Copy Markdown
Collaborator

Going to go ahead and merge this so we can try to get into release testing tomorrow after the delay.

@garrettwrong
garrettwrong merged commit 60d1db6 into develop Jul 8, 2025
95 of 100 checks passed
@j-c-c j-c-c mentioned this pull request Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants