Skip to content

resolve ambiguous dtype in Downsample - #1298

Merged
garrettwrong merged 2 commits into
developfrom
dtdbg
Jul 3, 2025
Merged

resolve ambiguous dtype in Downsample#1298
garrettwrong merged 2 commits into
developfrom
dtdbg

Conversation

@garrettwrong

Copy link
Copy Markdown
Collaborator

It's a brave new world out there.

(Pdb) out.real.dtype
dtype('float32')
(Pdb) out.real.get().dtype
dtype('float32')
(Pdb) (out.real * ds_res**2 / self.resolution**2).dtype
dtype('float64')
(Pdb) type(out)
<class 'cupy.ndarray'>
(Pdb) (out.real.get() * ds_res**2 / self.resolution**2).dtype
dtype('float32')

There are other ways to handle, but this seemed minimally invasive. Resolves the problem I was seeing in the pipeline demo.

@garrettwrong garrettwrong self-assigned this Jul 3, 2025
@garrettwrong garrettwrong added bug Something isn't working invalid This doesn't seem right extern Relating to external changes labels Jul 3, 2025
@garrettwrong
garrettwrong requested a review from j-c-c July 3, 2025 13:27
@codecov

codecov Bot commented Jul 3, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.60%. Comparing base (52d3ce6) to head (13544c9).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1298   +/-   ##
========================================
  Coverage    90.60%   90.60%           
========================================
  Files          133      133           
  Lines        14346    14346           
========================================
  Hits         12998    12998           
  Misses        1348     1348           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j-c-c j-c-c left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun stuff!

@garrettwrong
garrettwrong marked this pull request as ready for review July 3, 2025 13:58
@garrettwrong
garrettwrong requested a review from janden as a code owner July 3, 2025 13:58
@garrettwrong

Copy link
Copy Markdown
Collaborator Author

Merging.

@garrettwrong
garrettwrong merged commit 5cd8bc7 into develop Jul 3, 2025
44 checks passed
@garrettwrong
garrettwrong deleted the dtdbg branch July 3, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working extern Relating to external changes invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants