Skip to content

Validate ArrayImageSource stack dimension #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garrettwrong merged 2 commits into from
Aug 4, 2025
Merged

Validate ArrayImageSource stack dimension #1306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2b8754
Validate ArrayImageSource stack dim
garrettwrong Jul 28, 2025
d7915ba
Add test for ArrayImageSource stack validation
garrettwrong Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/aspire/source/image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1751,6 +1751,12 @@ def __init__(
f" Original error: {str(e)}"
)

# Now that we are an `Image`, check stack is 1D
if im.stack_ndim != 1:
raise RuntimeError(
"`ArrayImageSource` expects a single stack axis, received shape {im.shape}."
)

super().__init__(
L=im.resolution,
n=im.n_images,
Expand Down
11 changes: 11 additions & 0 deletions tests/test_array_image_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,3 +261,14 @@ def test_dtype_passthrough(dtype):
np.testing.assert_equal(src.images[:].dtype, dtype)
np.testing.assert_equal(src.amplitudes.dtype, dtype)
np.testing.assert_equal(src.offsets.dtype, dtype)


def test_stack_1d_only():
d = np.empty((2, 3, 4, 4))
img = Image(d)

with raises(RuntimeError, match=r"expects a single stack axis"):
_ = ArrayImageSource(d)

with raises(RuntimeError, match=r"expects a single stack axis"):
_ = ArrayImageSource(img)
Loading