Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1307 +/- ##
========================================
Coverage 90.60% 90.60%
========================================
Files 133 133
Lines 14348 14348
========================================
Hits 13000 13000
Misses 1348 1348 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
j-c-c
marked this pull request as ready for review
July 29, 2025 14:54
garrettwrong
approved these changes
Jul 29, 2025
garrettwrong
left a comment
Collaborator
There was a problem hiding this comment.
Great thanks.
Alternatively, you could also have just changed the base class CLOrient3D to default to None and/or eval None to 360 there. Explicit defaults work for me though 😇 😃 .
Collaborator
|
This appears low risk. Update and merge after all checks passed please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add default n_theta value for all commonline methods.
Resolves #1304