Skip to content

n_theta Default value - #1307

Merged
j-c-c merged 1 commit into
developfrom
n_theta
Aug 4, 2025
Merged

n_theta Default value#1307
j-c-c merged 1 commit into
developfrom
n_theta

Conversation

@j-c-c

@j-c-c j-c-c commented Jul 28, 2025

Copy link
Copy Markdown
Collaborator

Add default n_theta value for all commonline methods.

Resolves #1304

@j-c-c j-c-c self-assigned this Jul 28, 2025
@j-c-c j-c-c added the bug Something isn't working label Jul 28, 2025
@codecov

codecov Bot commented Jul 28, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.60%. Comparing base (95ed9c1) to head (3dfe5a5).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1307   +/-   ##
========================================
  Coverage    90.60%   90.60%           
========================================
  Files          133      133           
  Lines        14348    14348           
========================================
  Hits         13000    13000           
  Misses        1348     1348           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j-c-c
j-c-c marked this pull request as ready for review July 29, 2025 14:54

@garrettwrong garrettwrong left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks.

Alternatively, you could also have just changed the base class CLOrient3D to default to None and/or eval None to 360 there. Explicit defaults work for me though 😇 😃 .

@garrettwrong

Copy link
Copy Markdown
Collaborator

This appears low risk. Update and merge after all checks passed please.

@j-c-c
j-c-c merged commit 64adf5f into develop Aug 4, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants