Migrate pixel_size out of filter init - #1324
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1324 +/- ##
===========================================
- Coverage 90.62% 90.61% -0.02%
===========================================
Files 133 133
Lines 14394 14389 -5
===========================================
- Hits 13044 13038 -6
- Misses 1350 1351 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
j-c-c
reviewed
Sep 12, 2025
j-c-c
left a comment
j-c-c
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! Just two small things related to the recent pixel size PR that was merged.
garrettwrong
marked this pull request as ready for review
September 12, 2025 18:41
janden
approved these changes
Sep 24, 2025
janden
left a comment
janden
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for doing this. This looks like a lot of work.
All good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.