Fix Numpy pickle warnings - #1334
Conversation
6cdb0ed to
44609d4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1334 +/- ##
========================================
Coverage 90.65% 90.65%
========================================
Files 133 133
Lines 14433 14433
========================================
Hits 13084 13084
Misses 1349 1349 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks good, lets check the minimal numpy version we require can open the new files. If not we may need to reconsider. Also, do you know why they are different sizes? |
The minimal numpy version could not open the new files. Updated to using the
These were very small files, so a fair amount of the size was in overhead, ie. header and pickle protocol, which changed when saving with the new numpy version. |
garrettwrong
left a comment
There was a problem hiding this comment.
Awesome, much better approach, thanks
|
You can probably bypass Joakim on this one once all the CI clears. 🚀 |
Resolves #1333