Skip to content

Fix Numpy pickle warnings - #1334

Merged
j-c-c merged 2 commits into
developfrom
covar_test_warnings
Oct 22, 2025
Merged

Fix Numpy pickle warnings#1334
j-c-c merged 2 commits into
developfrom
covar_test_warnings

Conversation

@j-c-c

@j-c-c j-c-c commented Oct 21, 2025

Copy link
Copy Markdown
Collaborator

Resolves #1333

@j-c-c j-c-c self-assigned this Oct 21, 2025
@j-c-c j-c-c added bug Something isn't working CI Continuous Integration cleanup extern Relating to external changes labels Oct 21, 2025
@j-c-c
j-c-c marked this pull request as draft October 21, 2025 19:55
@j-c-c
j-c-c force-pushed the covar_test_warnings branch from 6cdb0ed to 44609d4 Compare October 21, 2025 19:55
@codecov

codecov Bot commented Oct 21, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.65%. Comparing base (8577e1d) to head (42c6aaf).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1334   +/-   ##
========================================
  Coverage    90.65%   90.65%           
========================================
  Files          133      133           
  Lines        14433    14433           
========================================
  Hits         13084    13084           
  Misses        1349     1349           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@garrettwrong

Copy link
Copy Markdown
Collaborator

Looks good, lets check the minimal numpy version we require can open the new files. If not we may need to reconsider.

Also, do you know why they are different sizes?

@j-c-c

j-c-c commented Oct 22, 2025

Copy link
Copy Markdown
Collaborator Author

Looks good, lets check the minimal numpy version we require can open the new files. If not we may need to reconsider.

The minimal numpy version could not open the new files. Updated to using the npz format and confirmed that the minimal numpy version can load the files. This involved a small refactor of the tests to handle the npz dicts.

Also, do you know why they are different sizes?

These were very small files, so a fair amount of the size was in overhead, ie. header and pickle protocol, which changed when saving with the new numpy version.

@garrettwrong garrettwrong left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, much better approach, thanks

@garrettwrong

Copy link
Copy Markdown
Collaborator

You can probably bypass Joakim on this one once all the CI clears. 🚀

@j-c-c
j-c-c marked this pull request as ready for review October 22, 2025 17:55
@j-c-c
j-c-c merged commit 96d442f into develop Oct 22, 2025
63 of 65 checks passed
@j-c-c j-c-c mentioned this pull request Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CI Continuous Integration cleanup extern Relating to external changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants