Skip to content

Cls indices fix - #1346

Merged
garrettwrong merged 4 commits into
developfrom
cls_indices_fix
Dec 8, 2025
Merged

Cls indices fix#1346
garrettwrong merged 4 commits into
developfrom
cls_indices_fix

Conversation

@garrettwrong

Copy link
Copy Markdown
Collaborator

Small patch. Mainly to address storing the alignment results someone may need for their project...

  • Fixes bug introduced with class source batching that was only saving the most recently aligned batch results (vars were just for potential reference).
  • Sets several progress bars to leave=False, less spammy
  • Couple minor string/logger updates

@garrettwrong garrettwrong self-assigned this Dec 4, 2025
@garrettwrong garrettwrong added bug Something isn't working documentation Improvements or additions to documentation cleanup labels Dec 4, 2025
@codecov

codecov Bot commented Dec 4, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.66%. Comparing base (c92fa17) to head (59cf2be).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1346      +/-   ##
===========================================
+ Coverage    90.65%   90.66%   +0.01%     
===========================================
  Files          134      134              
  Lines        14430    14446      +16     
===========================================
+ Hits         13082    13098      +16     
  Misses        1348     1348              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@garrettwrong
garrettwrong requested a review from j-c-c December 5, 2025 14:31

@j-c-c j-c-c left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@garrettwrong
garrettwrong marked this pull request as ready for review December 5, 2025 16:39
@garrettwrong
garrettwrong requested a review from janden as a code owner December 5, 2025 16:39
@garrettwrong

Copy link
Copy Markdown
Collaborator Author

Checked recon still good. Merging.

@garrettwrong
garrettwrong merged commit d7414d4 into develop Dec 8, 2025
44 checks passed
@garrettwrong
garrettwrong deleted the cls_indices_fix branch December 8, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cleanup documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants