Scikit Release breaking CI - #1348
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1348 +/- ##
===========================================
- Coverage 90.66% 90.66% -0.01%
===========================================
Files 134 134
Lines 14446 14455 +9
===========================================
+ Hits 13098 13105 +7
- Misses 1348 1350 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@garrettwrong, dropped that runner update in here too. Let me know if this looks good to you |
garrettwrong
requested changes
Dec 11, 2025
garrettwrong
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for fixing these. Wrong osx version; the patch will run osx 15 image twice...
garrettwrong
approved these changes
Dec 11, 2025
garrettwrong
left a comment
Collaborator
There was a problem hiding this comment.
Awesome. Can merge when the CI is satisfied. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Override scikit inverse_transform to allow for complex values.
Also updated the conda-build macos runner to version 15, since the macos-13 runner is now retired: actions/runner-images#13046