Skip to content

Scikit Release breaking CI - #1348

Merged
j-c-c merged 3 commits into
developfrom
scikit_bug
Dec 11, 2025
Merged

Scikit Release breaking CI#1348
j-c-c merged 3 commits into
developfrom
scikit_bug

Conversation

@j-c-c

@j-c-c j-c-c commented Dec 10, 2025

Copy link
Copy Markdown
Collaborator

Override scikit inverse_transform to allow for complex values.

Also updated the conda-build macos runner to version 15, since the macos-13 runner is now retired: actions/runner-images#13046

@j-c-c j-c-c self-assigned this Dec 10, 2025
@j-c-c j-c-c added bug Something isn't working CI Continuous Integration dependencies Pull requests that update a dependency file labels Dec 10, 2025
@codecov

codecov Bot commented Dec 10, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.66%. Comparing base (d7414d4) to head (91fa39a).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
src/aspire/numeric/complex_pca/complex_pca.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1348      +/-   ##
===========================================
- Coverage    90.66%   90.66%   -0.01%     
===========================================
  Files          134      134              
  Lines        14446    14455       +9     
===========================================
+ Hits         13098    13105       +7     
- Misses        1348     1350       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j-c-c

j-c-c commented Dec 11, 2025

Copy link
Copy Markdown
Collaborator Author

@garrettwrong, dropped that runner update in here too. Let me know if this looks good to you

@garrettwrong garrettwrong left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these. Wrong osx version; the patch will run osx 15 image twice...

https://github.com/actions/runner-images?tab=readme-ov-file

@garrettwrong garrettwrong left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Can merge when the CI is satisfied. Thanks!

@j-c-c
j-c-c merged commit 8ccdbc3 into develop Dec 11, 2025
35 checks passed
@j-c-c
j-c-c deleted the scikit_bug branch December 11, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CI Continuous Integration dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants