CLMatrix Intermediary Base Class (CL Reorg part 2) - #1352
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1352 +/- ##
===========================================
+ Coverage 90.74% 90.87% +0.12%
===========================================
Files 136 135 -1
Lines 14689 14672 -17
===========================================
+ Hits 13330 13333 +3
+ Misses 1359 1339 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Quick summary of work in this PR.
|
garrettwrong
previously approved these changes
Jan 9, 2026
| g_sync, | ||
| ) | ||
| from .commonline_base import CLOrient3D | ||
| from .commonline_matrix import CLMatrix |
Collaborator
There was a problem hiding this comment.
you got lucky with the abc's here :D
j-c-c
marked this pull request as ready for review
January 9, 2026 20:11
j-c-c
force-pushed
the
CLMatrix_rebased
branch
from
January 13, 2026 20:47
0b495ba to
5d3d25f
Compare
janden
requested changes
Jan 14, 2026
janden
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! Just a few things.
janden
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates an intermediary base class
CLMatrixto deploy the commonlines matrix build for only those classes that use it.