array shape patch for scipy 1.17.0 - #1354
Merged
Merged
Conversation
garrettwrong
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1354 +/- ##
========================================
Coverage 90.74% 90.74%
========================================
Files 136 136
Lines 14688 14689 +1
========================================
+ Hits 13329 13330 +1
Misses 1359 1359 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
j-c-c
approved these changes
Jan 13, 2026
j-c-c
left a comment
j-c-c
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! Glad we didn't need branches for different versions.
garrettwrong
marked this pull request as ready for review
January 13, 2026 14:16
Collaborator
Author
|
Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1353 . Got lucky, appears the old version admits the shape required by the latest version.