Skip to content

Filter stack and radial covar optimizations - #1388

Merged
garrettwrong merged 72 commits into
developfrom
rco_filter_stack
Jul 28, 2026
Merged

Filter stack and radial covar optimizations#1388
garrettwrong merged 72 commits into
developfrom
rco_filter_stack

Conversation

@garrettwrong

Copy link
Copy Markdown
Collaborator

Converts code towards filter stacks while maintaining ability to use legacy single filters (for now).

Provides a to_radial method for Filters.

Provides means to mix most singleton and stack filters. Vectorizes bulk evaluations.

Tries to vectorize (and sometimes use GPU when things fit) for filter_statck_to_basis_mats.

Add code paths to run radially optimized filter_stack_to_basis_mat.

Adds a smoke/timing test for covar2d using 10028 (ribsome) and 11618 (ctf per image) experimental sized cases.

Still a WIP, need self review.

@garrettwrong garrettwrong added enhancement New feature or request Optimization Performance or Resource Optimzation GPU labels Jun 11, 2026
@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.03504% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.65%. Comparing base (20a8ac2) to head (39bcdb4).

Files with missing lines Patch % Lines
src/aspire/operators/filters.py 96.02% 6 Missing ⚠️
src/aspire/basis/fle_2d.py 93.02% 3 Missing ⚠️
src/aspire/basis/ffb_2d.py 95.65% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1388      +/-   ##
===========================================
+ Coverage    90.56%   90.65%   +0.08%     
===========================================
  Files          135      135              
  Lines        14691    14926     +235     
===========================================
+ Hits         13305    13531     +226     
- Misses        1386     1395       +9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@garrettwrong
garrettwrong force-pushed the rco_filter_stack branch 2 times, most recently from 1102a7e to 5b5ea36 Compare June 22, 2026 18:47
@garrettwrong

Copy link
Copy Markdown
Collaborator Author

Going to kick off the full CI suite.

@garrettwrong
garrettwrong marked this pull request as ready for review July 8, 2026 13:57
@garrettwrong
garrettwrong requested a review from janden as a code owner July 8, 2026 13:57
@garrettwrong
garrettwrong requested a review from j-c-c July 8, 2026 14:36

@janden janden left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! A few questions here and there, but nothing major.

Comment thread src/aspire/basis/ffb_2d.py
Comment thread src/aspire/basis/ffb_2d.py
Comment thread src/aspire/image/image.py Outdated
Comment thread src/aspire/image/image.py Outdated
Comment thread src/aspire/operators/filters.py
Comment thread src/aspire/operators/filters.py Outdated
Comment thread src/aspire/operators/filters.py
@garrettwrong

Copy link
Copy Markdown
Collaborator Author

@janden for the _ctf_params and atleast_1d, just let me know what you'd prefer to see in the code and I'll change it if need be. Then I can have this back to you while I re-run all the tests. (That will take a while unfortunately).

@garrettwrong

Copy link
Copy Markdown
Collaborator Author

I was just informed our dev machines need to go down for maintenance. I'm going to merge this now in case there are issues with the updates. Can followup any outstanding concerns with small patches.

@garrettwrong
garrettwrong merged commit 5836ad2 into develop Jul 28, 2026
33 checks passed
@janden

janden commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Looked through everything and didn't see any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request GPU Optimization Performance or Resource Optimzation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants