Containerfile, removed LDAP requirement #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costowell
requested changes
Oct 14, 2025
There was a problem hiding this comment.
In our other repos, requirements.in always specifies version. Is that wrong?
There was a problem hiding this comment.
Honestly idk Python requirements.
There was a problem hiding this comment.
seems like they don't have to? the docs don't mention versioning requirements.in? I think the thought is you update requirements.txt only when you intentionally want to update stuff. ie requirement.txt works like normal and pip-compile/requirements.in are there to make updating without breaking dependencies easier
| from audiophiler.models import File, Harold, Auth, Tour | ||
| from audiophiler.util import * | ||
|
|
||
| # Create CSHLDAP connection |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it works !!!! it is cool!!! actual feature improvements soon:tm: maybe not from me maybe from @DeadPixelPro
sorry im sleepy