MXP redesign
#625
Open
MXP redesign
#625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierBBB
requested review from
letypequividelespoubelles and
lorenzogentile404
8 tasks
mxp_v3/generalities/shorthands.lisp
Outdated
| CT_MAX_MXPX (- nROWS_MXPX 1) | ||
| CT_MAX_UPDT_W (- nROWS_UPDT_W 1) | ||
| CT_MAX_UPDT_B (- nROWS_UPDT_B 1) | ||
| ) |
There was a problem hiding this comment.
I believe MXP constants need to be defined in a dedicated file if we want them to be included in Trace.java generated file in tracer later.
| (defun (mxp-shorthand---is-deploying) (force-bool (shift macro/DEPLOYING NEGATIVE_ROW_OFFSET___SCNRI_TO_MACRO))) | ||
| (defun (mxp-shorthand---is-RETURN) (force-bool (shift decoder/IS_RETURN NEGATIVE_ROW_OFFSET___SCNRI_TO_DECDR))) | ||
| (defun (mxp-shorthand---byte-price) (shift decoder/G_BYTE NEGATIVE_ROW_OFFSET___SCNRI_TO_DECDR)) | ||
| (defun (mxp-shorthand---real-byte-price) (if-zero (mxp-shorthand---is-RETURN) |
There was a problem hiding this comment.
Naming seems to be not 100 % consistent with specs, e.g., this is called gas_per_byte.
| (mxp-shorthand---byte-price)) | ||
| )) | ||
| (defun (mxp-shorthand---number-of-bytes) (mxp-shorthand---size-1-lo)) | ||
| (defun (mxp-shorthand---extra-byte-cost) (* (mxp-shorthand---size-1-lo) |
There was a problem hiding this comment.
In the the specs, (mxp-shorthand---number-of-bytes) is used to defined (mxp-shorthand---extra-byte-cost), but it is equivalent so it is up to us how much consistent we want to be with the specs.
- unified treatment for MLOAD, MSTORE, MSTORE8 - they all use (set-MXP-instruction---single-mxp-offset-instructions) - does not apply to CALLDATALOAD - new shorthand (stack-ram---fixed-size) which is 32, 32, 1 depending on the case
hub_into_mxp --> hub_into_mxp_london
hub_into_mxp_cancun
also removed MTNTOP from the cancun version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of Consensys/linea-specification#103