Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staterecovery adapt to new besu #642

Merged
merged 25 commits into from
Feb 6, 2025
Merged

Conversation

jpnovais
Copy link
Collaborator

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@jpnovais jpnovais temporarily deployed to docker-build-and-e2e January 31, 2025 14:28 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 34.37500% with 21 lines in your changes missing coverage. Please review.

Project coverage is 68.48%. Comparing base (b7d7e45) to head (1484ad8).

Files with missing lines Patch % Lines
.../consensys/zkevm/coordinator/app/L1DependentApp.kt 0.00% 10 Missing ⚠️
.../consensys/zkevm/coordinator/app/CoordinatorApp.kt 0.00% 6 Missing ⚠️
...src/main/kotlin/net/consensys/TypingsExtensions.kt 0.00% 2 Missing ⚠️
...ain/kotlin/linea/domain/MapperLineaDomainToBesu.kt 77.77% 1 Missing and 1 partial ⚠️
...in/src/main/kotlin/net/consensys/MathExtensions.kt 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #642      +/-   ##
============================================
+ Coverage     68.37%   68.48%   +0.11%     
- Complexity     1182     1185       +3     
============================================
  Files           323      323              
  Lines         13125    13130       +5     
  Branches       1316     1318       +2     
============================================
+ Hits           8974     8992      +18     
+ Misses         3599     3587      -12     
+ Partials        552      551       -1     
Flag Coverage Δ *Carryforward flag
hardhat 98.52% <ø> (ø) Carriedforward from fe496b8
kotlin 66.14% <34.37%> (+0.12%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...models/src/main/kotlin/linea/domain/Transaction.kt 35.45% <100.00%> (ø)
...in/src/main/kotlin/net/consensys/MathExtensions.kt 57.14% <66.66%> (+2.59%) ⬆️
...src/main/kotlin/net/consensys/TypingsExtensions.kt 79.06% <0.00%> (-1.89%) ⬇️
...ain/kotlin/linea/domain/MapperLineaDomainToBesu.kt 47.61% <77.77%> (+0.63%) ⬆️
.../consensys/zkevm/coordinator/app/CoordinatorApp.kt 0.00% <0.00%> (ø)
.../consensys/zkevm/coordinator/app/L1DependentApp.kt 1.46% <0.00%> (ø)

... and 2 files with indirect coverage changes

@jpnovais jpnovais requested a review from a team January 31, 2025 17:41
@jpnovais jpnovais force-pushed the staterecovery-adapt-to-new-besu branch from 666543c to 7913fb8 Compare February 5, 2025 09:50
@jpnovais jpnovais force-pushed the staterecovery-adapt-to-new-besu branch from 7913fb8 to 129a308 Compare February 5, 2025 12:14
@jpnovais jpnovais temporarily deployed to docker-build-and-e2e February 5, 2025 14:00 — with GitHub Actions Inactive
Filter94
Filter94 previously approved these changes Feb 5, 2025
@jpnovais jpnovais force-pushed the staterecovery-adapt-to-new-besu branch from 03c147e to c6c7f27 Compare February 5, 2025 15:41
@jpnovais jpnovais temporarily deployed to docker-build-and-e2e February 5, 2025 15:42 — with GitHub Actions Inactive
@jpnovais jpnovais temporarily deployed to docker-build-and-e2e February 5, 2025 17:29 — with GitHub Actions Inactive
@jpnovais jpnovais temporarily deployed to docker-build-and-e2e February 5, 2025 18:29 — with GitHub Actions Inactive
@jpnovais jpnovais temporarily deployed to docker-build-and-e2e February 5, 2025 19:03 — with GitHub Actions Inactive
@jpnovais jpnovais requested a review from Filter94 February 5, 2025 19:32
Filter94
Filter94 previously approved these changes Feb 6, 2025
jonesho
jonesho previously approved these changes Feb 6, 2025
@jpnovais jpnovais dismissed stale reviews from jonesho and Filter94 via 1484ad8 February 6, 2025 09:48
@jpnovais jpnovais temporarily deployed to docker-build-and-e2e February 6, 2025 09:49 — with GitHub Actions Inactive
@jpnovais jpnovais requested review from jonesho and Filter94 February 6, 2025 10:24
@jpnovais jpnovais merged commit 4d85082 into main Feb 6, 2025
22 checks passed
@jpnovais jpnovais deleted the staterecovery-adapt-to-new-besu branch February 6, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants