Qbft spike #67
Qbft spike #67
Conversation
| kvStoreAccessor.get(Schema.BlockRootByBlockNumber, blockNumber).getOrNull()?.let { blockRoot -> | ||
| return getSealedBeaconBlock(blockRoot) | ||
| } | ||
| return null |
There was a problem hiding this comment.
I don't think you need a separate return statement. I believe you should be able to pop it before kvStoreAccessor.get(...
| } | ||
|
|
||
| private val proposerSelector = | ||
| object : ProposerSelector { | ||
| override fun getProposerForBlock(header: BeaconBlockHeader): SafeFuture<Validator> = | ||
| override fun selectProposerForRound(header: BeaconBlockHeader): SafeFuture<Validator> = |
There was a problem hiding this comment.
FYI, I changed it to accept ConsensusRoundIdentifier instead in another PR. here is the relevant discussion.
I see you've added the required getSealedBeaconBlock(blockNumber: ULong) to the BeaconChain, so we're aligned here
There was a problem hiding this comment.
Now I see that you've added another ProposerSelector accepting ConsensusRoundIdentifier, so this one can be removed now
| @@ -24,6 +24,7 @@ allprojects { | |||
| apply plugin: 'java-library' | |||
|
|
|||
| repositories { | |||
| mavenLocal() | |||
There was a problem hiding this comment.
Should this go into maru/buildSrc/src/main/groovy/maru.kotlin-common-minimal-conventions.gradle?
There was a problem hiding this comment.
I was planning to remove this before any code is merged in. Just a temporary until we have a Besu release out with the changes I need.
| messageFactory, | ||
| ) | ||
|
|
||
| val transitionLogger = QbftValidatorModeTransitionLoggerAdapter() |
There was a problem hiding this comment.
What kind of transition is it? From a non-validator to a validator and vise versa?
There was a problem hiding this comment.
It's a transition to a new block. I don't think we need this interface; we should be able to remove it and just add a subscriber to the new block event in Besu. If I can do that, I'll remove this as I don't like this QbftValidatorModeTransitionLogger.
Spike of integrating Qbft into Maru
DO NOT MERGE