Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove latestBeaconBlockRoot from BeaconState #71

Merged

Conversation

gauravahuja
Copy link
Contributor

@gauravahuja gauravahuja commented Mar 28, 2025

After #70 and #65 we can remove latestBeaconBlockRoot from BeaconState

  • We already have body root in latestBeaconBlockHeader
  • We can also calculate block root using latestBeaconBlockHeader.hash

@gauravahuja gauravahuja requested review from jframe and Filter94 March 28, 2025 06:10
@gauravahuja gauravahuja force-pushed the gauravahuja/remove_beacon_block_root_from_beacon_state branch from a20efea to 1c6beff Compare March 28, 2025 06:16
@gauravahuja gauravahuja changed the base branch from gauravahuja/beaconchain-updates to gauravahuja/60-qbft-block-validator March 28, 2025 06:17
jframe
jframe previously approved these changes Mar 28, 2025
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Filter94
Filter94 previously approved these changes Mar 28, 2025
@gauravahuja gauravahuja dismissed stale reviews from Filter94 and jframe via aa4b097 March 31, 2025 23:11
@gauravahuja gauravahuja changed the base branch from gauravahuja/60-qbft-block-validator to main March 31, 2025 23:11
@gauravahuja gauravahuja changed the base branch from main to gauravahuja/60-qbft-block-validator March 31, 2025 23:11
Base automatically changed from gauravahuja/60-qbft-block-validator to main April 2, 2025 08:58
@gauravahuja gauravahuja merged commit 77d01b3 into main Apr 2, 2025
3 checks passed
@gauravahuja gauravahuja deleted the gauravahuja/remove_beacon_block_root_from_beacon_state branch April 2, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants