Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging during sync #9244

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

StefanBratanov
Copy link
Contributor

PR Description

Fixed Issue(s)

fixes #9220

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Copy link
Contributor

@gfukushima gfukushima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, with a question on the return of SyncManager::getSyncStatus

peerSync.getStartingSlot(),
new SyncingTarget(
new SlotAndBlockRoot(bestPeerStatus.getHeadSlot(), bestPeerStatus.getHeadRoot()),
1));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the const 1 here might be a bit misleading if it comes out in one of the logs, should we print the total amount of peers instead even though they might not all have the same target?

@tbenr
Copy link
Contributor

tbenr commented Mar 18, 2025

let's put this LOG back to debug too

return findCommonAncestor(latestFinalizedSlot, targetChain)
.thenPeek(ancestor -> LOG.info("Found common ancestor at slot {}", ancestor));

@tbenr tbenr added the DO NOT MERGE Not ready to merge label Mar 19, 2025
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added an experimental change to the PR, adding more info taken from the BatchSync.
It is not good in the current form but we can play with it until we find the final form.

@tbenr tbenr force-pushed the improve_logging_sync branch from 8be0071 to a79fcf0 Compare March 19, 2025 18:30
@StefanBratanov
Copy link
Contributor Author

Hoodi syncing

image

@StefanBratanov StefanBratanov removed the DO NOT MERGE Not ready to merge label Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve logging/reporting during sync
3 participants