Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix on StartupLog #9276

Merged
merged 5 commits into from
Mar 26, 2025
Merged

Conversation

lucassaldanha
Copy link
Member

@lucassaldanha lucassaldanha commented Mar 26, 2025

  • We were logging details about validator API even when it was disabled.
  • Also rewrote the unit tests so we have one test case per report entry.

Copy link
Contributor

@gfukushima gfukushima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lucassaldanha lucassaldanha enabled auto-merge (squash) March 26, 2025 01:25
final HardwareAbstractionLayer hardwareInfo = mock(HardwareAbstractionLayer.class);
final GlobalMemory memory = mock(GlobalMemory.class);
when(hardwareInfo.getMemory()).thenReturn(memory);
when(memory.getTotal()).thenReturn(Long.valueOf("123"));

Check notice

Code scanning / CodeQL

Missing catch of NumberFormatException Note test

Potential uncaught 'java.lang.NumberFormatException'.
@lucassaldanha lucassaldanha merged commit 4462bec into Consensys:master Mar 26, 2025
16 checks passed
@lucassaldanha lucassaldanha deleted the fix-status-log branch March 26, 2025 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants