Jenaic - Server express socket tmi #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Salut Jenaic, Terrible ta PR, je te remercie ! Tout marche impec, j'ai checkouté la PR et merge sur le main. Du coup mini review ici : vu que tout fonctionne, j'ai seulement passé le code en typescript en changeant deux ou trois choses côté package, et roule :D Je check la partie client et let's go ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
J'ai mis les instructions dans ./server/README.md
J'ai aussi attaché le démarrage du serveur avec ton
npm run devdu front, donc une commande to run them allEnsuite, tu peux checker que tout fonctionne dans la console sur le http://localhost:3001
Ce dossier public est inutile, il sert juste à vérifier, donc tu pourras le supp après