chore(bun): upgrade to Bun 1.4.2 and pin the version in one place - #502
Draft
DavidBabinec wants to merge 1 commit into
Draft
chore(bun): upgrade to Bun 1.4.2 and pin the version in one place#502DavidBabinec wants to merge 1 commit into
DavidBabinec wants to merge 1 commit into
Conversation
Bun moves from 1.3.11 to 1.4.2, and the version stops being written in ten places. package.json now carries "packageManager": "bun@1.4.2", which oven-sh/setup-bun reads by default, so the six workflow steps in ci.yml and release.yml drop their explicit bun-version. The Dockerfile declares ARG BUN_VERSION=1.4.2 once and the three stages build from it. The engines range widens to >=1.4.0 <1.5.0. Bumping Bun is now two lines (the packageManager field and the ARG), and the Docker gate test asserts that shape. The bootstrap determinism note in scripts/sync-plugin-bootstrap.ts names the new range and image. Nothing else had to change: install with the frozen lockfile, tsc, the Vite build, lint, and the full test suite all pass under 1.4.2 with the lockfile untouched, and the committed QuickJS bootstrap artifacts are byte-identical under the new bundler (bootstrap:check). Why now: 1.4 brings a native React Compiler in bun build, 2x faster startup and less than half the memory on Linux, and 1.4.1 fixed a run of node:http and socket lifecycle bugs (Vite port-retry hang, paused sockets never emitting end, ws handleUpgrade after await, WebSocket backpressure) that map onto the dev-server workarounds this repo carries. Those get re-tested and, where the fixes hold, deleted in a follow-up on top of this pin bump, so each step stays reviewable on its own. Verification (isolated Bun 1.4.2, global stays 1.3.11): bun install --frozen-lockfile clean, lockfile unchanged bun run bootstrap:check fresh, 2 artifacts byte-identical bun run icons:check clean bun run build tsc + vite clean bun run lint clean bun test 6836 pass, 0 fail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Bun moves from 1.3.11 to 1.4.2, and the version is written in two places instead of ten.
package.jsongains"packageManager": "bun@1.4.2", whichoven-sh/setup-bun@v2reads by default, so the sixbun-version:inputs inci.ymlandrelease.ymlare gone.DockerfiledeclaresARG BUN_VERSION=1.4.2once; the three stages buildFROM oven/bun:${BUN_VERSION}.engines.bunwidens to>=1.4.0 <1.5.0.dockerConfig.test.tsasserts the ARG and the templatedFROM; the bootstrap determinism note inscripts/sync-plugin-bootstrap.tsnames the new range and image.Bumping Bun next time is the
packageManagerfield and theARG.Why
1.4 brings a native React Compiler in
bun build, 2x faster startup and under half the memory on Linux, and 1.4.1 fixed a run ofnode:httpand socket lifecycle bugs (the Vite port-retry hang, paused sockets never emittingend,wshandleUpgradeafter anawait, WebSocket backpressure stalls) that map onto the dev-server workarounds this repo carries. Those get re-tested on top of this pin bump and, where the fixes hold, deleted in a follow-up, so each step stays reviewable on its own.Impact
bun run devrefuses older versions through the engines range.oven/bun:1.4.2; nothing in the runtime path changed.bun-version: 1.3.11ine2e.yml; it drops that input when it rebases onto this.Verification
Isolated Bun 1.4.2 binary in a fresh worktree off
main(the global 1.3.11 untouched):bun install --frozen-lockfilebun.lockunchangedbun run bootstrap:checkbun run icons:checkbun run buildbun run lintbun testbun test src/__tests__/server/dockerConfig.test.tsCI on this PR is the Linux proof; the local run is macOS.