-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(new tools): Data Storage/Transfer Units Converter #1289
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…Converter New Tool: Data Transfer Rate Converter New Tool: Data Storage Units Converter (with MB, MiB and Mb) Fix CorentinTh#539 CorentinTh#785 CorentinTh#1160 CorentinTh#848 Data Storage Units Converter inspired by CorentinTh#948 by @utf26
…evb/it-tools into feat/storage-transfer-units
Also the separators look wrong to me. Should be a dot for decimals instead of a comma in English and vice versa? |
Hi @steffenrapp, I would have also said MB is 1024² but in fact MB is decimal 1000² and MiB is binary 1024² : https://en.wikipedia.org/wiki/Megabyte ; confusing, I admit |
Hi @steffenrapp, regarding comma or dot, the display use your browser language but right, it should be always English |
Sorry my bad 🤦🏻♂️ |
787971d
to
fd31da2
Compare
fd31da2
to
f4e2aef
Compare
f4e2aef
to
b385da6
Compare
b385da6
to
66dd351
Compare
Hi @steffenrapp, implemented "always dot" (and no thousand separator) as your bug report. Thanks, it is clearer now. |
Hi @sharevb what do you think if the decimal separator would be depending on the selected language? Might be a general global implementation to define and later use those rules. |
Hi @steffenrapp, I am not sure it is not confusing to present as local formating (at least for this tool, since it is IT tools, it is supposed to be IT formating) and also because I presume you have a German language on your computer and you were surprise that it was "1.000,00" |
Hi @sharevb I understand your perspective and think it makes sense like that. A general decision for the product should be made by @CorentinTh if he wants some clear guidelines. EDIT: Yes my devices are German 😀 In fact I was confused because I had English select in the tool and it was the German formatting. |
Waiting for this new tool! Thanks!! |
Hi @sharevb , can you add fullname like this, for more details |
Quality Gate passedIssues Measures |
Hi @quyvsquy (and @steffenrapp and @CorentinTh) added label for units (right, it is better, thanks) |
Hi @sharevb Nice looks good 👍🏼 |
New Tool: Data Transfer Rate Converter
New Tool: Data Storage Units Converter (with MB, MiB and Mb)
Fix #539 #785 #1160 #848
Data Storage Units Converter inspired by #948 by @utf26