Fix: Add proper error handling for db_path in server API#2
Open
Fix: Add proper error handling for db_path in server API#2
Conversation
echobt
added a commit
that referenced
this pull request
Jan 19, 2026
…main--components--term-challenge chore(main): release 0.1.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds explicit error handling for database path resolution failures in the server API endpoints.
Problem
The status() and search() endpoints in src/server/api.rs were using state.config.db_path().unwrap_or_default() to obtain the database path. When db_path() fails (which returns Result), unwrap_or_default() silently converts the error into an empty PathBuf.
This is problematic because:
Solution
Replaced unwrap_or_default() with explicit error handling using match expressions. When db_path() fails, the API now:
The changes affect:
Testing
The fix has been verified by code review. The changes ensure proper error propagation follows the same pattern used elsewhere in the codebase for other error conditions.
Related Issue
Fixes PlatformNetwork/bounty-challenge#36