Skip to content

Fix: Restrict CORS to localhost origins for security #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
echobt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Restrict CORS to localhost origins for security #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/server/api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ use serde::{Deserialize, Serialize};
use std::net::SocketAddr;
use std::path::PathBuf;
use std::sync::{Arc, Mutex};
use tower_http::cors::{Any, CorsLayer};
use axum::http::{HeaderValue, Method};
use tower_http::cors::CorsLayer;

use crate::config::Config;
use crate::core::{Database, EmbeddingEngine};
Expand Down Expand Up @@ -103,10 +104,19 @@ pub async fn run_server(config: &Config, host: &str, port: u16) -> Result<()> {
config,
});

// Restrict CORS to localhost origins only for security
// This prevents malicious websites from making cross-origin requests to the local server
let allowed_origins = [
"http://localhost".parse::<HeaderValue>().unwrap(),
"http://127.0.0.1".parse::<HeaderValue>().unwrap(),
format!("http://localhost:{}", port).parse::<HeaderValue>().unwrap(),
format!("http://127.0.0.1:{}", port).parse::<HeaderValue>().unwrap(),
];

let cors = CorsLayer::new()
.allow_origin(Any)
.allow_methods(Any)
.allow_headers(Any);
.allow_origin(allowed_origins)
.allow_methods([Method::GET, Method::POST, Method::OPTIONS])
.allow_headers([axum::http::header::CONTENT_TYPE, axum::http::header::ACCEPT]);

let app = Router::new()
.route("/", get(root))
Expand Down
Loading