Open
Conversation
echobt
added a commit
that referenced
this pull request
Jan 19, 2026
…main--components--term-challenge chore(main): release 0.2.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change ensures the health check function properly validates the server response instead of only checking if a TCP connection and write operation succeeded.
Problem
The health() function in src/server/client.rs only verified that it could establish a TCP connection and write an HTTP request. It immediately returned true after a successful write without reading or validating the server response. This means a hung or malfunctioning server that accepts connections but never responds would still be reported as healthy, potentially causing cascading failures in systems relying on accurate health status.
Solution
Modified the health() function to:
This ensures that the health check accurately reflects whether the server is actually processing requests and responding correctly.
Testing
The fix follows the same HTTP response reading pattern used by the search() and embed_batch() methods in the same file, which have been working correctly. The health check will now return false if:
Related Issue
Fixes PlatformNetwork/bounty-challenge#19