Fix: Correct chunk overlap calculation to use actual character count#6
Open
Fix: Correct chunk overlap calculation to use actual character count#6
Conversation
echobt
added a commit
that referenced
this pull request
Jan 19, 2026
…main--components--term-challenge chore(main): release 0.2.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change corrects the chunk overlap calculation to properly count characters instead of using an arbitrary division by 40.
Problem
The original implementation calculated overlap by dividing the configured chunk_overlap value by 40, under the assumption that lines average 40 characters. This approach was flawed:
Solution
The fix implements proper character-based overlap calculation by:
This ensures the overlap accurately reflects the configured character count, improving indexing consistency across files with varying line lengths.
Testing
The fix maintains the same function signature and behavior contract. The changes affect:
Related Issue
Fixes PlatformNetwork/bounty-challenge#22