Fix: Indexer logs file read errors instead of swallowing them#9
Open
Fix: Indexer logs file read errors instead of swallowing them#9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modified the indexer to log specific file read errors instead of silently incrementing the 'skipped' counter.
Problem
Previously, when the indexer encountered an error reading a file (e.g., permission denied, invalid UTF-8), it caught the error generically with Err(_) => skipped += 1, giving the user no indication of why files were skipped or which files failed.
Solution
Updated the match block in both Indexer and ServerIndexer to capture the error Err(e) and print a warning message with the file path and error details using pb.println. This ensures the progress bar display remains intact while informing the user of issues.
Testing
Confirmed via code analysis that the Err(_) arm was swallowing errors. The fix now explicitly logs Failed to read file {path}: {error} to the console.
Related Issue
Fixes PlatformNetwork/bounty-challenge#47