Outsourcing routines to new package cs_util #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: sp_validation/cat.py sp_validation/plots.py
This comment has been minimized.
This comment has been minimized.
|
@martinkilbinger I don't have any objection to this, but
|
Conflicts: sp_validation/basic.py
I've done these two action items. |
Unit Test Report 1 files 1 suites 19s ⏱️ For more details on these errors, see this check. Results for commit 0885903. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to outsource some commonly used functions to a new library
cs_util.These functions are used not only within
sp_validationbut alsoshapepipeand other CosmoStat packages.The creation of a new library solves the problem #36 of inter-dependency between different packages.
Also helps with #46.