-
Notifications
You must be signed in to change notification settings - Fork 69
Tests for Graph controller index method #1548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for Graph controller index method #1548
Conversation
Pull Request Test Coverage Report for Build d3bd2bd0-601f-4ade-9a89-87a71e1efdcbDetails
💛 - Coveralls |
import Controllers.CourseControllerTests (courseControllerTestSuite) | ||
import Controllers.GraphControllerTests (graphControllerTestSuite) | ||
import Test.HUnit (Test (..)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this change (you moved this import statement to a different line)
@@ -9,8 +9,10 @@ module Controllers.ControllerTests | |||
( controllerTests ) where | |||
|
|||
import Test.HUnit (Test (..)) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like if I don't add this space here, then the import statements get ordered alphabetically upon commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yoonieaj nice work. Yes, I believe the coverage went down because of the new Courseography modules added. There's something a bit weird about our cabal setup for the tests vs. the Courseography module, which I've made a note to look into later.
Proposed Changes
Adds tests for the
index
method inControllers/Graph.sh
....
Screenshots of your changes (if applicable)
Type of Change
(Write an
X
or a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]
into a[x]
in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
Is the decrease in test coverage related to the additions to the
.cabal
file?