Skip to content

Tests for Graph controller index method #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 20, 2025

Conversation

yoonieaj
Copy link
Contributor

@yoonieaj yoonieaj commented May 18, 2025

Proposed Changes

Adds tests for the index method in Controllers/Graph.sh.

...

Screenshots of your changes (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests) X
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.
  • I have updated the project Changelog (this is required for all changes).

After opening your pull request:

  • I have verified that the CircleCI checks have passed.
  • I have requested a review from a project maintainer.

Questions and Comments

Is the decrease in test coverage related to the additions to the .cabal file?

@coveralls
Copy link

coveralls commented May 18, 2025

Pull Request Test Coverage Report for Build d3bd2bd0-601f-4ade-9a89-87a71e1efdcb

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-9.0%) to 31.741%

Totals Coverage Status
Change from base Build 6288a076-605e-47c8-8bef-cc18d1e79ad8: -9.0%
Covered Lines: 637
Relevant Lines: 1933

💛 - Coveralls

@yoonieaj yoonieaj marked this pull request as draft May 18, 2025 03:49
@yoonieaj yoonieaj marked this pull request as ready for review May 18, 2025 03:49
import Controllers.CourseControllerTests (courseControllerTestSuite)
import Controllers.GraphControllerTests (graphControllerTestSuite)
import Test.HUnit (Test (..))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this change (you moved this import statement to a different line)

@@ -9,8 +9,10 @@ module Controllers.ControllerTests
( controllerTests ) where

import Test.HUnit (Test (..))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like if I don't add this space here, then the import statements get ordered alphabetically upon commit

@yoonieaj yoonieaj requested a review from david-yz-liu May 20, 2025 20:18
Copy link
Contributor

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoonieaj nice work. Yes, I believe the coverage went down because of the new Courseography modules added. There's something a bit weird about our cabal setup for the tests vs. the Courseography module, which I've made a note to look into later.

@david-yz-liu david-yz-liu merged commit 3fa4031 into Courseography:master May 20, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants