-
Notifications
You must be signed in to change notification settings - Fork 70
Rename post table to program #1607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Rename post table to program #1607
Conversation
|
Hey David, while waiting on the CI for this PR (it failed due to a time limit exceeded error), I noticed some inefficiencies in our CI config I thought could potentially be improved. Here's what i found:
I'd be happy to explore this in seperate PRs; let me know what you think! |
|
Hi @akarki2005, thanks for the ping. I'm re-running the CI build now. You're absolutely correct that how we're handling the dependency caching is not optimal. I'd be happy for you to explore both of your suggestions in a separate PR. |
Pull Request Test Coverage Report for Build c1af5ae6-6501-463e-8e2b-3f62f7a4d663Details
💛 - Coveralls |
david-yz-liu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akarki2005 nice work! I left a few comments. Sorry for taking a few days for this review. :)
4e02bb7 to
a49e6f3
Compare
… into rename-post-table-to-program
Proposed Changes
This PR renames the
PostandPostCategorytables in the Courseography database toProgramandProgramCategoryrespectively.Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request: