Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.21.1] Fix Processing Output not applying data components #8105

Merged
merged 5 commits into from
Mar 27, 2025
Merged

[1.21.1] Fix Processing Output not applying data components #8105

merged 5 commits into from
Mar 27, 2025
+31 −15

Conversation

RaymondBlaze
Copy link

Also optimized rollOutput for case when chance is 100%, and added count / chance validation in codec.

See #7945 (comment).

@VoidLeech VoidLeech added pr type: fix PR fixes a bug pr flag: simple PR has minimal changes labels Mar 24, 2025
lcy0x1
lcy0x1 suggested changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@lcy0x1 lcy0x1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getStack() still doesn't have the patch applied

@RaymondBlaze
Fix getStack and use getStack for rollOutput
b684c94 
Add overload for datagenOutput with components
@RaymondBlaze
Copy link
Author

getStack() still doesn't have the patch applied

Fixed, also removed the behaviour of getStack() checking for datagenOutput, since it's not used in datagen and there's no point to do so.

@IThundxr
Copy link
Member

Thanks!

@IThundxr IThundxr merged commit 9e061d2 into Creators-of-Create:mc1.21.1/dev Mar 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcy0x1 lcy0x1 lcy0x1 requested changes

Assignees
No one assigned
Labels
pr flag: simple PR has minimal changes pr type: fix PR fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RaymondBlaze @IThundxr @lcy0x1 @VoidLeech