Promote ubi8 Dockerfile #800
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohit-joy
reviewed
May 3, 2025
|
|
||
| ARG ENCRYPTED_PRIVATE_KEY_SECRET | ||
|
|
||
| ARG PLAT=x86_64 | ||
| ARG RUBY_VERSION=3.2.0 |
rohit-joy
reviewed
May 3, 2025
|
|
||
| RUN gem install bundler && bundle config set deployment true && DOCKER_ENV=true RACK_ENV=production bundle install | ||
| COPY . $APP_PATH | ||
|
|
||
| COPY docker-entrypoint.sh /usr/bin/ |
rohit-joy
reviewed
May 3, 2025
| ARG RUBY_VERSION=3.3.5 | ||
| FROM ruby:${RUBY_VERSION} | ||
| # Use Red Hat Universal Base Image 8 | ||
| FROM registry.access.redhat.com/ubi8/ubi:latest |
There was a problem hiding this comment.
Seems that using latest is a SAST issue. I think you can use a specific version like this 8.10-1262.
Or perhaps even UBI 9: https://catalog.redhat.com/software/containers/ubi9/ubi/615bcf606feffc5384e8452e?container-tabs=packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are promoting ubi8 dockerfile as the official one.
Resolves: 779