fix fluent#9368: unsigned integer overflow

Crispy-fried-chicken · Sep 9, 2024 · 8539cfc · 8539cfc
1 parent 072ffe7
commit 8539cfc
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/lib/cmetrics/src/external/protobuf-c.c b/lib/cmetrics/src/external/protobuf-c.c
@@ -2604,10 +2604,13 @@ parse_required_member(ScannedMember *scanned_member,
 			return FALSE;
 
 		def_mess = scanned_member->field->default_value;
-		subm = protobuf_c_message_unpack(scanned_member->field->descriptor,
-						 allocator,
-						 len - pref_len,
-						 data + pref_len);
+		if (len >= pref_len)
+			subm = protobuf_c_message_unpack(scanned_member->field->descriptor,
+							 allocator,
+							 len - pref_len,
+							 data + pref_len);
+		else
+			subm = NULL;
 
 		if (maybe_clear &&
 		    *pmessage != NULL &&