Skip to content

test: add multiply and divide functions #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CristianAmbrosini wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: add multiply and divide functions #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions calculator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,13 @@ def process_scores(scores: list[int]) -> dict:
"average": sum(scores) / len(scores),
"max": max(scores),
}


def multiply(a, b):
return a * b
Comment on lines +43 to +44

@sonar-review-dev18 sonar-review-dev18 Bot Apr 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic duplication: multiply is already defined at line 29 with type annotations (a: int, b: int) -> int). In Python the last definition wins, so the typed version is now dead code — callers silently get this untyped one. Remove this definition (the one at line 29 is the right one to keep).

  • Mark as noise



def divide(a, b):
if b == 0:
raise ValueError("Cannot divide by zero")
return a / b
Comment on lines +47 to +50

@sonar-review-dev18 sonar-review-dev18 Bot Apr 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic duplication: divide is already defined at line 9 with type annotations (a: float, b: float) -> float) and identical zero-division logic. This definition shadows it, making the typed version dead code. Remove this duplicate.

Missing test coverage: Whichever divide survives has no tests for either the happy path or the zero-division guard. A regression (e.g. the guard being dropped) would go undetected. Add at least: assert divide(6, 2) == 3 and a check that divide(1, 0) raises ValueError.

  • Mark as noise

Loading