Skip to content

test: scenario 1 - failing tests before sonar scanner - #41

Open
CristianAmbrosini wants to merge 2 commits into
mainfrom
test/scenario1-failing-tests
Open

test: scenario 1 - failing tests before sonar scanner#41
CristianAmbrosini wants to merge 2 commits into
mainfrom
test/scenario1-failing-tests

Conversation

@CristianAmbrosini

Copy link
Copy Markdown
Owner

Testing check-run watching: tests fail before sonar scanner step. Bot should detect the failed check run and abandon the candidate immediately without waiting 30 min.

@sonar-review-dev18

sonar-review-dev18 Bot commented Apr 30, 2026

Copy link
Copy Markdown

Summary

This PR introduces a failing test step to the SonarQube workflow to validate check-run detection logic. The "Run tests" step intentionally exits with code 1 before the SonarQube scan executes. The change also includes a retrigger marker file. This is a test scenario designed to verify that an automated bot correctly detects failed check runs and abandons processing immediately rather than waiting for a 30-minute timeout.

What reviewers should know

What this tests: The bot's ability to watch GitHub check runs and react to test failures that occur before the SonarQube scanning step completes.

Key points for review:

  • The failing test step is placed intentionally early in the workflow (before SonarQube scan)
  • The exit 1 ensures the job fails and surfaces as a failed check run on the PR
  • The test-retrigger.txt file is a metadata marker for test orchestration
  • This is temporary test infrastructure — expect these changes to be removed or modified once the check-run detection behavior is validated

Where to start: Look at the workflow timing and how the bot's check-run listener is configured to understand the expected abandonment behavior.


  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

sonar-review-dev18[bot]

This comment was marked as outdated.

@sonar-review-dev18 sonar-review-dev18 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

🗣️ Give feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant