Skip to content

test: scenario 3 - no sonar scanner in GHA workflow - #43

Open
CristianAmbrosini wants to merge 3 commits into
mainfrom
test/scenario3-no-scanner
Open

test: scenario 3 - no sonar scanner in GHA workflow#43
CristianAmbrosini wants to merge 3 commits into
mainfrom
test/scenario3-no-scanner

Conversation

@CristianAmbrosini

Copy link
Copy Markdown
Owner

Testing fallback behavior: GHA workflow exists but has no sonar scanner step. Bot should detect no scanner, keep all candidates, and fall back to 30-min SQC polling (no check-run watcher built). Since no scanner runs, SQC analysis will never arrive → bot should timeout after 30 min and proceed with AI-only review.

@sonar-review-dev18

sonar-review-dev18 Bot commented Apr 30, 2026

Copy link
Copy Markdown

Summary

This PR removes the SonarQube scanner step from the GitHub Actions workflow and replaces it with a placeholder lint job. This deliberately sets up a test scenario where the workflow exists but contains no sonar scanner—allowing the system to validate its fallback behavior.

Changes:

  • sonarcloud.yml: Removed SonarSource/sonarqube-scan-action step and replaced with a dummy Run linter job that echoes success
  • test-retrigger-s3.txt: Added trigger file to re-run this test scenario

This is intentional test infrastructure, not a breakage. The bot should detect the missing scanner step and fall back to 30-minute SonarCloud polling (no check-run watcher). Since the scanner never runs, SQC analysis will never arrive—the bot should timeout and proceed with AI-only review.

What reviewers should know

What you're reviewing:
A deliberate test case for fallback behavior, not production changes. Look for bot logic that:

  1. Parses the workflow file and detects that SonarQube scanner is missing
  2. Falls back to polling SonarCloud for up to 30 minutes
  3. Handles the timeout gracefully when no analysis arrives
  4. Proceeds with AI-only review when SQC polling times out

Key files to understand:

  • The workflow now has no scanner step—this is the setup, not a bug
  • The test-retrigger-s3.txt file is just a trigger; focus on how the bot responds to the missing scanner

Watch for:

  • Whether the bot correctly identifies "no scanner in workflow" vs "scanner present but failed"
  • How gracefully it handles the 30-minute poll timeout
  • Whether AI-only review still produces valid results

  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

sonar-review-dev18[bot]

This comment was marked as outdated.

@sonar-review-dev18 sonar-review-dev18 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

🗣️ Give feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant