Skip to content

test: verify aurora migration - #45

Open
CristianAmbrosini wants to merge 1 commit into
mainfrom
test/verify-aurora-migration
Open

test: verify aurora migration#45
CristianAmbrosini wants to merge 1 commit into
mainfrom
test/verify-aurora-migration

Conversation

@CristianAmbrosini

Copy link
Copy Markdown
Owner

Test PR to verify the new sc_rds Aurora cluster works correctly on dev18.

@sonar-review-dev18

sonar-review-dev18 Bot commented May 11, 2026

Copy link
Copy Markdown

Summary

This PR sets up SonarCloud integration for automated code quality scanning. It adds a GitHub Actions workflow that triggers SonarCloud scans on push to main and on all PRs, along with the required sonar-project.properties configuration file. A test file (A.py) with intentional bugs is included to verify the scan detection is working correctly. The calculator module is simplified as part of the test setup.

The "aurora migration" referenced in the description likely refers to verifying that the SonarCloud backend infrastructure (AWS Aurora) is working properly on the dev18 environment.

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

What reviewers should know

Key files to review:

  • .github/workflows/sonarcloud.yml — The workflow that enables automated SonarCloud scanning
  • sonar-project.properties — Project configuration (Python version 3, scan scope)
  • A.py — Contains intentional bugs for verifying SonarCloud detects issues (accessing attributes on potentially None values)

What to look for:

  • Verify the SonarCloud token and host URL are being passed correctly from GitHub Secrets
  • Check that the scan triggers on the right events (PR opened/synchronized/reopened, push to main)
  • The A.py file has deliberate bugs for testing — this is intentional
  • The calculator.py simplification is expected as part of the test setup

Potential considerations:

  • The .DS_Store file is a macOS system file and may not be needed in version control
  • Ensure SonarCloud secrets are properly configured in GitHub repository settings before this PR is merged

  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

@sonar-review-dev18 sonar-review-dev18 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

🗣️ Give feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant