Skip to content

test: verify enablement flow #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CristianAmbrosini wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: verify enablement flow #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions palindrome.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
def is_palindrome(s: str) -> bool:
cleaned = s.lower().replace(" ", "")

@sonar-review-dev18 sonar-review-dev18 Bot May 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The normalization strips spaces but not other non-alphanumeric characters (punctuation, tabs, hyphens, etc.). The canonical palindrome example "A man, a plan, a canal: Panama" returns False with the current implementation.

If the function is meant to handle natural-language strings, the cleaned step should strip all non-alphanumeric characters instead of just spaces.

Suggested change
cleaned = s.lower().replace(" ", "")
cleaned = "".join(c for c in s.lower() if c.isalnum())
  • Mark as noise

return cleaned == cleaned[::-1]

Loading