Skip to content

test: verify latest deploy #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CristianAmbrosini wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: verify latest deploy #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions list_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
from typing import Optional


def find_max(numbers: list[int]) -> Optional[int]:
if not numbers:
return None
return max(numbers)
Comment on lines +4 to +7

@sonar-review-dev18 sonar-review-dev18 Bot May 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing docstrings — required by org guidelines.

All public functions must have docstrings describing what the function does, its parameters, and its return value. Both find_max() and flatten() are missing them.

Suggested change
def find_max(numbers: list[int]) -> Optional[int]:
if not numbers:
return None
return max(numbers)
def find_max(numbers: list[int]) -> Optional[int]:
"""Return the maximum value in a list of integers, or None if the list is empty.
Args:
numbers: A list of integers.
Returns:
The maximum integer, or None if the list is empty.
"""
if not numbers:
return None
return max(numbers)
  • Mark as noise



def flatten(nested: list[list]) -> list:
return [item for sublist in nested for item in sublist]
Comment on lines +10 to +11

@sonar-review-dev18 sonar-review-dev18 Bot May 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing docstring — required by org guidelines. Also, the type hint list[list] implies every element must itself be a list, but the implementation silently skips or raises TypeError if a sublist contains non-iterable items (e.g. [[1, 2], 3] raises TypeError: 'int' object is not iterable with no clear message).

Add a docstring and consider whether the function should validate its input or document the assumption explicitly.

Suggested change
def flatten(nested: list[list]) -> list:
return [item for sublist in nested for item in sublist]
def flatten(nested: list[list]) -> list:
"""Flatten a list of lists into a single list.
Args:
nested: A list where each element is itself a list.
Returns:
A single flat list containing all items from the sublists.
Raises:
TypeError: If any element of `nested` is not iterable.
"""
return [item for sublist in nested for item in sublist]
  • Mark as noise


Loading