Fix security and stability issues from code review#17
Merged
Conversation
Critlist
commented
Jun 6, 2026
Critlist
commented
Owner
- Format string vulns: pline(xprname()) in invent.c, pline(buf) in options.c
- UB: free() on arena-allocated topten entry in end.c
- Null deref: getenv("HOME") in pager.c child(); add setuid(getuid()) drop before exec
- OOB read: ep[-1] when ep==NULL in dowhatis()
- Save system: sr_u16 removed (was panic-backed, now replaced with safe read() in check_save_header); fd leaks on three dorecover() early-return paths; save_pos typed off_t not long; lseek failure branched separately from "too old" path
- Signal safety: resize_pending changed to volatile sig_atomic_t
- Format string vulns: pline(xprname()) in invent.c, pline(buf) in options.c
- UB: free() on arena-allocated topten entry in end.c
- Null deref: getenv("HOME") in pager.c child(); add setuid(getuid()) drop before exec
- OOB read: ep[-1] when ep==NULL in dowhatis()
- Save system: sr_u16 removed (was panic-backed, now replaced with safe read() in
check_save_header); fd leaks on three dorecover() early-return paths; save_pos
typed off_t not long; lseek failure branched separately from "too old" path
- Signal safety: resize_pending changed to volatile sig_atomic_t
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.