Split TokenIF into external and internal interfaces#3424
Draft
emilydrakesmith wants to merge 3 commits into
Draft
Split TokenIF into external and internal interfaces#3424emilydrakesmith wants to merge 3 commits into
TokenIF into external and internal interfaces#3424emilydrakesmith wants to merge 3 commits into
Conversation
✅ Deploy Preview for ambient-finance ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
Actually splitting the original // this interface conforms to the industry standard token data obj shape
export interface ServerTokenIF {
name: string;
address: string;
symbol: string;
decimals: number;
chainId: number;
logoURI: string;
}
// this interface extends the industry standard with our own internal decorations
export interface TokenIF extends ServerTokenIF {
fromList?: string;
listedBy?: string[];
walletBalance?: string;
dexBalance?: string;
}Completion of this project requires a few more steps.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
TokenIFintoServerTokenIF(conforms to industry standard) andTokenIF(internal standard decorate by post-processing middleware).Link the related issue
Closes #3422
Checklist before requesting a review
docs/CODING-STYLE.md?Instructions for Reviewers
Functionalities or workflows that should specifically be tested.
Syntactic sugar for dev experience and support only. This PR should not result in any behavioral changes in the app.
Environmental conditions that may result in expected but differential behavior.
none
If relevant, list additional work to complete pre-merge (delete logging, code abstraction, etc)