Use RPC calls for vault balances#4959
Merged
Merged
Conversation
✅ Deploy Preview for futa-finance ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for dev-ambi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for plume-ambient-finance ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for monad-ambient-finance ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
benwolski
approved these changes
May 20, 2025
Collaborator
|
tested balance queries, deposits and withdrawals. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR replaces an API call to get user vault balances with onchain queries. It also updates the SDK version to bring in minor vault improvements.
Link the related issue
Closes #0000
Checklist before requesting a review
docs/CODING-STYLE.md?Instructions for Reviewers
Functionalities or workflows that should specifically be tested.
Environmental conditions that may result in expected but differential behavior.
If relevant, list additional work to complete pre-merge (delete logging, code abstraction, etc)