Closed
Conversation
adamtulinius
force-pushed
the
cleanup-cli-parsing
branch
2 times, most recently
from
1732484 to
a789c05
Compare
Move the CLI parsing to a separate pkg, thus moving a tonne of code from morph.go. Introduce a new common.MorphConfig to keep most options. This is probably more of a temporary measure, but removes a lot of global state for now.
adamtulinius
force-pushed
the
cleanup-cli-parsing
branch
from
a789c05 to
0eac686
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #248
cleanup: extract CLI-parsing to separate pkg
Move the CLI parsing to a separate pkg, thus moving a tonne of code
from morph.go.
Introduce a new common.MorphConfig to keep most options.
This is probably more of a temporary measure, but removes a lot of
global state for now.