-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proposal for terminating KREAd vats #4
base: develop
Are you sure you want to change the base?
Add proposal for terminating KREAd vats #4
Conversation
## Description The purpose of this PR is to update the KREAd frontend code to use the JSON API instead of the deprecated RPC method to query the Vstorage. With this in mind, it was necessary to update the `@agoric/rpc` and `@agoric/web-components` packages, and the respective imported functions being used by KREAd. Changes made to original code: - At commit 5c6bdaf the packages mentioned above are updated to the latest version. - At commit 42f886f - the `fetchChainInfo` function is updated to return the `api` along with the `rpc` and `chainName` - the `connectAgoric` function is updated to pass the `rpc` as argument to `makeAgoricWalletConnection` - the `startWatching` function is updated to pass the `api` as argument to `makeAgoricChainStorageWatcher` - At commit fbeeedb on all calls of the `watchLatest` method of `chainStorageWatcher`, the `onError` argument was removed, since it is no longer expected. ## Related Issues Fixes the following issues: - [#4](Jorge-Lopes#4) - [#9145](Agoric/agoric-sdk#9145) ## Checklist Make sure all items are checked before submitting the pull request. Remove any items that are not applicable. - [x] The PR title is clear and concise. - [x] Are there changes in the /fronted folder? Make sure `cd frontend && yarn build` runs successfully.;
The test calls |
The purpose of including the
The are no post-build tests for the
Thank you very much for bringing this to my attention. I failed to notice that the submissions were not being commited since they are included in the gitignore. I’ve fixed this issue |
b7e413c
to
8bdf0e6
Compare
I'm confused. The new state only has one changed file (src/proposal/terminate-kread.js). I was expecting to see an updated
After #211, the ability to terminate vats should be present and |
@Chris-Hibbert sorry, I have decided to improve my implementation to allow the use of the |
ff43505
to
8bdf0e6
Compare
closes: https://github.com/Agoric/BytePitchPartnerEng/issues/46
Description
As part of the sunsetting process for the KREAd application, it is necessary to terminate the KREAd contract, governor, committee, and charter vats. This step is essential to ensure a clean and secure shutdown of the application and to free up associated resources.
This PR introduces:
Key Changes
Core-Eval Script:
A3P-Integration Enhancements:
Environment Setup:
Testing Considerations
The x:kread proposal was introduced to test the behaviour of the executing the KREAd terminating core-eval, as well as test how it handles new offer requests to the KREAd contract after terminated.
The z:acceptance proposal confirms that the Agoric chain remains functional after the termination of KREAd vats.
Note that it is necessary to update the value of
AGORIC_SDK_ROOT
at the agoric/a3p-integration/.env with the one from your local environment. And then execute the agoric/a3p-integration/agoric-sdk-symlink.sh script.After executing these 2 steps, the remaining steps are the same as usual.
Additional Considerations
After merging this PR, the next logical step would be to create a new release. This release should include artifacts generated by the agoric run command, which can then be utilized with the Cosmos Proposal Builder.
Generated artifacts will be available in agoric/a3p-integration/proposals/x:kread/kread-submission.