Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability to log on a step-based interval in OffPolicyAlgorithm #1709

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

tobiabir
Copy link

@tobiabir tobiabir commented Oct 6, 2023

Description

  • Removed log_interval argument from collect_rollouts in OffPolicyAlgorithm
  • Added logging in learn of OffPolicyAlgorithm instead
  • Fixed documentation of the functionality of log_interval
  • Swapped logging and training in learn for both OffPolicyAlgorithm and OnPolicyAlgorithm
  • Updated default values for log_interval for off-policy algorithms
  • Updated changelog

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have opened an associated PR on the SB3-Contrib repository (if necessary)
  • I have opened an associated PR on the RL-Zoo3 repository (if necessary)
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)
  • I have checked that the documentation builds using make doc (required)

Note: You can run most of the checks using make commit-checks.

Note: we are using a maximum length of 127 characters per line

@tobiabir tobiabir changed the title [Draft] Add capability to log on a step-based interval in OffPolicyAlgorithm Add capability to log on a step-based interval in OffPolicyAlgorithm Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add capability to log on a step-based interval in OffPolicyAlgorithm
1 participant