Removes unneeded transactions. #2909
Open
+116
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuupke
force-pushed
the
Feature/remove-transactions
branch
2 times, most recently
from
eda63ec to
73b1804
Compare
tuupke
force-pushed
the
Feature/remove-transactions
branch
from
73b1804 to
f427290
Compare
tuupke
force-pushed
the
Feature/remove-transactions
branch
9 times, most recently
from
14f4141 to
9284d1c
Compare
tuupke
force-pushed
the
Feature/remove-transactions
branch
from
9284d1c to
00f98e2
Compare
|
Just the first three transactions. But can be merged. Probably easiest to check commit-by-commit. |
meisterT
reviewed
Jul 5, 2025
| @@ -910,37 +910,22 @@ public function internalErrorAction(Request $request): ?int | |||
| */ | |||
| protected function giveBackJudging(int $judgingId, ?Judgehost $judgehost): void | |||
| { | |||
| // Reset the judgings without using Doctrine, it has no support for update queries containing a join. | |||
| ->getArrayResult(); | ||
|
|
||
| if ($rows == 0) { | ||
| // TODO, handle this case. Nothing was updated. |
There was a problem hiding this comment.
Is there anything to be handled? If there is no outstanding that we would disable here, we don't have an issue, do we?
There was a problem hiding this comment.
Fair point, I'll remove.
Reading this back, this cannot be correct! I've had to create a manual query for updates with joins. 🤯
Apparently this case is never hit in the testsuite either.
Tried removing this transaction for the removal of all unneccesary transactions. It turns out that this is actually a valid usecase that should be kept.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.