When no mapping to CLICS role exists, map to first role #3164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meisterT
reviewed
Oct 25, 2025
| } | ||
|
|
||
| return null; | ||
| return $this->getRoleList()[0]; |
There was a problem hiding this comment.
Is this list guaranteed to be non empty?
vmcj
reviewed
Oct 25, 2025
| protected static array $accountAddCombinationsWithoutFile = [ | ||
| [['username' => 'cds', 'roles' => ['admin']], ['roles' => ['api_source_reader', 'api_reader', 'api_writer'], 'type' => 'admin']], | ||
| [['username' => 'another_judgehost', 'roles' => ['judgehost']], ['type' => null]], | ||
| [['username' => 'another_judgehost', 'roles' => ['judgehost']], ['type' => 'judgehost']], |
There was a problem hiding this comment.
Suggested change
| [['username' => 'another_judgehost', 'roles' => ['judgehost']], ['type' => 'judgehost']], | |
| [['username' => 'another_judgehost', 'roles' => ['judgehost']], ['type' => 'dj_judgehost']], |
| "username" => "judgehost", | ||
| "team_id" => null, | ||
| "type" => null, | ||
| "type" => "judgehost", |
There was a problem hiding this comment.
Suggested change
| "type" => "judgehost", | |
| "type" => "dj_judgehost", |
This is so specific to DOMjudge that prefixing is better in case it ever ends up in another system...
|
Closing in favor of #3165 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3163